refactor(mobile): entities and models #9182
Conversation
Deploying immich with
|
| Latest commit: |
744fc7d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c9b228b0.immich.pages.dev |
| Branch Preview URL: | https://chore-mobile-refactor-entiti.immich.pages.dev |
|
Bit of a drive-by, but should this include a change to the model_template and corresponding block in the README? |
|
@avidal Makes sense, we are still working on restructuring that so potentially that template might be gone as well |
There was a problem hiding this comment.
asset_viewer/image_providerscould be a top-level module.home/ui/asset_gridcould just be a top-level module ofasset_grid.- I'm not a fan of the
sharedmodule, but it was there before so this doesn't need to address that now. I only bring it up in case others have better ideas what to do with it. uiandviewsort of mean the same thing to me when I look at the modules. It seems likeuiis made up of composible Widget components whileviewis made up of pages of the application which compose from theui. Maybe we can renameviewtopage?
Thank you for making this massive improvement! It was long overdue.
There was a problem hiding this comment.
Maybe this can live in backup/services
|
Looking forward to the restructured code base! I agree with @jrasm91, instead of another level of nesting (domain), let us directly have folders for entities, models, ... one level higher up. Also agree with @martyfuhry, but we can do these changes in another PR. |
|
A lot of web projects use a |
entitiesmodels